Arbitrary conditional vault #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metaproph3t
force-pushed
the
arbitrary-conditional-vault
branch
from
759409e to
d0bf35f
Compare
|
I will try to give this a read through when i get a chance if that's helpful |
0xbigz
reviewed
Aug 28, 2024
| /// Once resolved, the sum of all outcome resolutions is exactly 1. | ||
| #[account] | ||
| pub struct Question { | ||
| pub question_id: [u8; 32], |
There was a problem hiding this comment.
32 characters might be kinda smol, if its just an ID (and not characters) why do it like this?
There was a problem hiding this comment.
it's supposed to be a hash
metaproph3t
changed the base branch from
develop
to
arbitrary-conditional-vault
metaproph3t
merged commit 54dd6fa
into
metaDAOproject:arbitrary-conditional-vault
1 check passed
0xbigz
reviewed
Sep 10, 2024
|
|
||
| total_redeemable += ((user_conditional_token_account.amount as u128 | ||
| * question.payout_numerators[payout_index] as u128) | ||
| / question.payout_denominator as u128) as u64; |
There was a problem hiding this comment.
doing a mix of Solana Context and (unsafe) math logic within one function. would be great to split up math and state modification logic from solana account loader stuff. this makes rust tests much easier to write and lets you fuzz more easily
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.