Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create proposal tx method #235

Merged

Conversation

LukasDeco
Copy link
Contributor

No description provided.

@LukasDeco LukasDeco marked this pull request as ready for review June 25, 2024 23:56
@R-K-H R-K-H requested a review from metaproph3t June 26, 2024 00:01
@metaproph3t
Copy link
Member

what's the purpose of this change?

@LukasDeco
Copy link
Contributor Author

what's the purpose of this change?

Actually I need to make a change here. But the purpose is to just create a method for proposal initialization. I will need a proposal that will return an array of the transactions in the correct order and that we can sign them and send them to the jito bundle. That's what I'm working on here essentially but... this doesn't do that obviously because it uses .rpc(). This I guess will just work on devnet and won't really work on mainnet too well so... I might just mark this as draft for now.

@LukasDeco LukasDeco marked this pull request as draft June 26, 2024 04:41
@LukasDeco LukasDeco marked this pull request as ready for review June 28, 2024 01:03
@LukasDeco
Copy link
Contributor Author

@metaproph3t this is ready now but not sure why anchor test is failing?

Copy link
Member

@metaproph3t metaproph3t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LukasDeco LukasDeco merged commit 83ee059 into metaDAOproject:develop Jun 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants