chore: add container cmd check in start_stack.sh #1340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: reidliu <[email protected]>
reidliu41
requested review from
ashwinb,
yanxi0830,
hardikjshah,
dltn,
raghotham,
dineshyv,
vladimirivic,
sixianyi0721,
ehhuang and
terrytangyuan
as code owners
facebook-github-bot
added
the
CLA Signed
ashwinb
approved these changes
Mar 1, 2025
ashwinb
pushed a commit
that referenced
this pull request
Mar 3, 2025
# What does this PR do? [Provide a short summary of what this PR does and why. Link to relevant issues if applicable.] Sorry for the #1340 logic, it will cause issue if in `non-container` env. ``` Using conda <<<<<<<------ environment: stack + is_command_available docker + command -v docker + printf '\033[0;31mError: docker command not found. Is docker installed and in your PATH?\033[0m' Error: docker command not found. Is docker installed and in your PATH?+ exit 1 ``` [//]: # (If resolving an issue, uncomment and update the line below) [//]: # (Closes #[issue-number]) ## Test Plan [Describe the tests you ran to verify your changes with result summaries. *Provide clear instructions so the plan can be easily re-executed.*] [//]: # (## Documentation) Signed-off-by: reidliu <[email protected]> Co-authored-by: reidliu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
[Provide a short summary of what this PR does and why. Link to relevant issues if applicable.]
Test Plan
[Describe the tests you ran to verify your changes with result summaries. Provide clear instructions so the plan can be easily re-executed.]