Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: RAG with documents #1337

Merged
merged 1 commit into from
Mar 1, 2025
Merged

fix: RAG with documents #1337

merged 1 commit into from
Mar 1, 2025
+66 −0

Conversation

ehhuang
Copy link
Contributor

@ehhuang ehhuang commented Mar 1, 2025

Summary:
This was broken by https://github.com/meta-llama/llama-stack/pull/1015/files#r1975394190

Test Plan:

added e2e test

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Mar 1, 2025
@ehhuang ehhuang force-pushed the pr1337 branch 2 times, most recently from b52eefb to 4fde1c7 Compare March 1, 2025 00:44
@ehhuang ehhuang merged commit 21ec673 into main Mar 1, 2025
5 checks passed
@ehhuang ehhuang deleted the pr1337 branch March 1, 2025 00:51
@dmartinol
Copy link
Contributor

I tested the fix with the llama-stack-apps examples and also with the new e2e test and they don't work.
Looks like the tool is not invoked at all (I also debugged and can't see the MemoryToolRuntimeImpl.invoke_tool method ever called.
The e2e test fails because len(tool_execution_step) is 0 instead of >=1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yanxi0830 yanxi0830 yanxi0830 approved these changes

@ashwinb ashwinb Awaiting requested review from ashwinb ashwinb is a code owner

@hardikjshah hardikjshah Awaiting requested review from hardikjshah hardikjshah is a code owner

@dltn dltn Awaiting requested review from dltn dltn is a code owner

@raghotham raghotham Awaiting requested review from raghotham raghotham is a code owner

@dineshyv dineshyv Awaiting requested review from dineshyv dineshyv is a code owner

@vladimirivic vladimirivic Awaiting requested review from vladimirivic vladimirivic is a code owner

@sixianyi0721 sixianyi0721 Awaiting requested review from sixianyi0721 sixianyi0721 is a code owner

@terrytangyuan terrytangyuan Awaiting requested review from terrytangyuan terrytangyuan is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ehhuang @dmartinol @yanxi0830 @facebook-github-bot