fix(cli): Missing default for --image-type in stack run command #1274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuan Tang <[email protected]>
terrytangyuan
requested review from
ashwinb,
yanxi0830,
hardikjshah,
dltn,
raghotham,
dineshyv,
vladimirivic,
sixianyi0721 and
ehhuang
as code owners
facebook-github-bot
added
the
CLA Signed
|
Yes, I just noticed, sorry about that! If this PR gets approved and merged, we will have to revert this 😅 |
|
+1 thank you! |
yanxi0830
approved these changes
Feb 26, 2025
|
+1, thanks! |
srikanthbachala20
pushed a commit
to srikanthbachala20/llama-stack
that referenced
this pull request
Feb 27, 2025
…-llama#1274) # What does this PR do? I think this got accidentally removed as part of meta-llama#1250. cc @leseb ## Test Plan After the change, this arg is no longer required. Signed-off-by: Yuan Tang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
I think this got accidentally removed as part of #1250. cc @leseb
Test Plan
After the change, this arg is no longer required.