-
Notifications
You must be signed in to change notification settings - Fork 608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make DocQA a one-clickable app implementation #151
Conversation
@wukaixingxp I wonder if there is a chance to consolidate app.py and MacA.py? |
Co-authored-by: Hamid Shojanazeri <[email protected]>
Sure, there is a different behavior regarding how to launch Ollama between MacQA.py and app.py, maybe I can have a system env "USE_DOCKER" to control that. Update on Jan 13: The merge has been completed in f610415. Please take a look |
@ashwinb I updated the MacQA app to work with v0.1 and this PR is ready for review. Can you take a look at this PR and any feedback is greatly appreciated! CC: @HamidShojanazeri @raghotham |
@hardikjshah @ehhuang It would be good to have your feedback here. I will take a look at this in a bit too (today.) |
@ashwinb @hardikjshah Gentle reminder on this.. given that this PR has been here for more than a month now.. Thanks! Any feedback is welcomed. |
@HamidShojanazeri I talked to @raghotham last week for this PR review. The idea is to make things simpler so that user can follow, thus we will remove the DockerQA as it is not very easy to use and maintain. Also the UI has been changed from using 'localhost in browser to a python GUI. Here is the modified one-clickable app, please take a look and let me know what do you think. |
Besides the comment from @hardikjshah, there are things need to address: 1. Add Ollama pull then ollama run |
Now (1) (2) (4) has been fixed, but this PR was not merged in v0.1.4. also v0.1.4 has some small problems: meta-llama/llama-stack#1255, so we need to switch back to v0.1.3. @hardikjshah Please take another look at this PR, thanks! |
@hardikjshah I noticed the this PR has been merged, but given the comment here, I do not think Ollama 1B & 3B can work with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
leaving a few comments but looks good to go. Going to approve to get it out
What does this PR do?
This PR adds a one-clickable app implementation of DocQA example, where user can choose local provider like Ollama or cloud provider like together or fireworks to do RAG. It allows users to install the
DocQA
app into the Application folder from theDocQA.dmg
file. ThisMacQA
app leverages llama-stack newLlamaStackAsLibraryClient
feature and make every agentic component in-line. This PR also explains the steps for building this app.This DocQA app will replace the existing docker solution as the docker solution is not easy to user and maintain.
Before submitting
Pull Request section?
to it if that's the case.
Thanks for contributing 🎉!