Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minizip-ng: add #562

Merged
merged 1 commit into from
Aug 15, 2022
Merged

minizip-ng: add #562

merged 1 commit into from
Aug 15, 2022

Conversation

neheb
Copy link
Collaborator

@neheb neheb commented Aug 12, 2022

Signed-off-by: Rosen Penev [email protected]

@neheb neheb force-pushed the xzzz branch 3 times, most recently from 5c43951 to 3d0c0f6 Compare August 12, 2022 03:02
@eli-schwartz
Copy link
Member

No.

Minizip is part of zlib, feel free to update that to provide the "minizip" dependency. Zlib-ng isn't API/ABI compatible and upstream acknowledges this by making it provide "libminizip-ng.so" and 'minizip-ng.pc"

@neheb
Copy link
Collaborator Author

neheb commented Aug 12, 2022

sure. that's why there's a compatibility switch.

@eli-schwartz
Copy link
Member

eli-schwartz commented Aug 12, 2022

I don't want a compatibility switch.

I want incompatible software to stop offering the ability to break stuff, but I can't make zlib-ng do anything they don't want to do. As far as the WrapDB is concerned, I want incompatible software to not list "minizip" in its provides section when it doesn't. By implication that also means minizip-ng can't default to providing the TBH broken claim of compatibility.

@neheb
Copy link
Collaborator Author

neheb commented Aug 12, 2022

works for domoticz.

anyway, I'll rework to remove it.

@neheb neheb force-pushed the xzzz branch 3 times, most recently from 43a8c0e to 68b9f32 Compare August 12, 2022 03:54
@neheb
Copy link
Collaborator Author

neheb commented Aug 12, 2022

 Installing subprojects\minizip-ng-3.0.6\minizip-ng.dll to D:\a\wrapdb\wrapdb\_build\pkg\bin

ERROR: File 'subprojects\\minizip-ng-3.0.6\\minizip-ng.lib' could not be found

is this a bug? the change here is the name from minizip to minizip-ng.

@neheb neheb force-pushed the xzzz branch 3 times, most recently from 114f4f3 to 63ed651 Compare August 12, 2022 23:54
@neheb
Copy link
Collaborator Author

neheb commented Aug 13, 2022

No tests defined.
s.
======================================================================
ERROR: test_releases (__main__.TestReleases) (step='check_new_release', name='minizip-ng')
----------------------------------------------------------------------
Traceback (most recent call last):
  File "D:\a\wrapdb\wrapdb\tools\sanity_checks.py", line 204, in test_releases
    self.check_new_release(name)
  File "D:\a\wrapdb\wrapdb\tools\sanity_checks.py", line 298, in check_new_release
    subprocess.check_call(['meson', 'install', '-C', builddir, '--destdir', 'pkg'])
  File "C:\hostedtoolcache\windows\Python\3.9.13\x64\lib\subprocess.py", line 373, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['meson', 'install', '-C', '_build', '--destdir', 'pkg']' returned non-zero exit status 1.

I'm all ears.

@neheb neheb force-pushed the xzzz branch 5 times, most recently from 65e519f to b148494 Compare August 13, 2022 02:28
@neheb
Copy link
Collaborator Author

neheb commented Aug 13, 2022

I see the issue. Upstream exports nothing without compat enabled. I don't feel like working around this.

@neheb
Copy link
Collaborator Author

neheb commented Aug 13, 2022

According to zlib-ng/minizip-ng#475 , upstream relies on CMake's EXPORT_ALL_SYMBOLS

@neheb neheb force-pushed the xzzz branch 7 times, most recently from b49f8d0 to 85de380 Compare August 14, 2022 01:57
@neheb neheb force-pushed the xzzz branch 3 times, most recently from 52c2a85 to df836df Compare August 14, 2022 02:14
@neheb
Copy link
Collaborator Author

neheb commented Aug 14, 2022

alright this is ready.

Signed-off-by: Rosen Penev <[email protected]>
@jpakkane jpakkane merged commit 3169bdc into mesonbuild:master Aug 15, 2022
@neheb neheb deleted the xzzz branch August 27, 2022 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants