-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
minizip-ng: add #562
minizip-ng: add #562
Conversation
5c43951
to
3d0c0f6
Compare
No. Minizip is part of zlib, feel free to update that to provide the "minizip" dependency. Zlib-ng isn't API/ABI compatible and upstream acknowledges this by making it provide "libminizip-ng.so" and 'minizip-ng.pc" |
sure. that's why there's a compatibility switch. |
I don't want a compatibility switch. I want incompatible software to stop offering the ability to break stuff, but I can't make zlib-ng do anything they don't want to do. As far as the WrapDB is concerned, I want incompatible software to not list "minizip" in its provides section when it doesn't. By implication that also means minizip-ng can't default to providing the TBH broken claim of compatibility. |
works for domoticz. anyway, I'll rework to remove it. |
43a8c0e
to
68b9f32
Compare
is this a bug? the change here is the name from minizip to minizip-ng. |
114f4f3
to
63ed651
Compare
I'm all ears. |
65e519f
to
b148494
Compare
I see the issue. Upstream exports nothing without compat enabled. I don't feel like working around this. |
According to zlib-ng/minizip-ng#475 , upstream relies on CMake's EXPORT_ALL_SYMBOLS |
b49f8d0
to
85de380
Compare
52c2a85
to
df836df
Compare
alright this is ready. |
Signed-off-by: Rosen Penev <[email protected]>
Signed-off-by: Rosen Penev [email protected]