backends: Make ninja not build test executables by default #5867
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When they're marked
build_by_default : false
This soles the easy part, which is making ninja not build test dependencies if they're explicitly marked
build_by_default : false
. A completely fix will require some deeper changes to not affect backwards compatibility, as currently all targets default tobuild_by_default=True
.This shouldn't affect the VSCode backend since tests are generated separately, but I could be wrong.
I'm thinking moving to a tri-state value equivalent to Always, If-not-test, never.
Fixes #2518
Fixes #1704