Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Linear ASM compiler #13989

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Add Linear ASM compiler #13989

merged 1 commit into from
Jan 9, 2025

Conversation

Freed-Wu
Copy link
Contributor

@Freed-Wu Freed-Wu commented Dec 9, 2024

Fix #13670

PS:

  • same feature for cmake
  • feature request for xmake

@Freed-Wu Freed-Wu force-pushed the linearasm branch 7 times, most recently from dcaaab8 to 5c74747 Compare December 9, 2024 17:02
@Freed-Wu
Copy link
Contributor Author

Freed-Wu commented Dec 9, 2024

Now it works for me 😄

Copy link
Member

@dcbaker dcbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This deserves a release snippet, otherwise this all looks good to me.

@Freed-Wu
Copy link
Contributor Author

Freed-Wu commented Dec 9, 2024

What is a release snippet?

BTW, I use name TILinearAsmCompiler for *.sa. because cmake want to use ASM_LINEAR.

Currently, only c6000 support linear assemble *.sa. see cl6x --help | grep linear asm can find it.
other TI compilers for chip cl2000, cl430, armcl, tiarmcl don't support it. so we check it in sanity_check()

@dcbaker
Copy link
Member

dcbaker commented Dec 9, 2024

A release snippet is a small markdown description of the feature that will be put into the release notes when we cut 1.7.0, they go in docs/markdown/snippets, you can look at the existing snippets to see what they should look like.

mesonbuild/compilers/asm.py Outdated Show resolved Hide resolved
mesonbuild/compilers/asm.py Outdated Show resolved Hide resolved
mesonbuild/compilers/detect.py Outdated Show resolved Hide resolved
mesonbuild/compilers/detect.py Show resolved Hide resolved
@Freed-Wu
Copy link
Contributor Author

Any other problem? I have tested this PR in this project and it can work.

@Freed-Wu Freed-Wu force-pushed the linearasm branch 2 times, most recently from 2d1d52a to dbe741e Compare January 9, 2025 03:42
Copy link
Member

@dcbaker dcbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With Eli's comments addressed this looks good to me.

@eli-schwartz eli-schwartz dismissed their stale review January 9, 2025 05:35

my comments have been addressed now

@jpakkane jpakkane merged commit 910db36 into mesonbuild:master Jan 9, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature] Support linear assembly of TI DSP
4 participants