-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend documentation on environment variables #583
Conversation
CI failure is Sphinx version too old:
Will add a second commit for that. |
This should fix the CI failure that was visible on mesonbuildgh-583 due to `sphinxcontrib.applehelp` at least requiring Sphinx 5.0. Upgrading the Furo theme may also improve the html output; we're pulling in almost two years worth of fixes here. [skip cirrus]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rgommers. Looks nice, except a couple of small things.
This should fix the CI failure that was visible on mesonbuildgh-583 due to `sphinxcontrib.applehelp` at least requiring Sphinx 5.0. Upgrading the Furo theme may also improve the html output; we're pulling in almost two years worth of fixes here.
79823c7
to
83fe22b
Compare
Thanks @rgommers. I was indeed wondering why sphynx was pinned to such an old release. Just one more thing: maybe the commit messages should follow the usual convention and be prepended with |
- cross link to the tables of compiler/linker flags in the Meson docs - mention `PKG_CONFIG_PATH` - add a warning about Conda's habit of injecting env vars also on the environment variables reference page Closes mesonbuildgh-460
This should fix the CI failure that was visible on mesonbuildgh-583 due to `sphinxcontrib.applehelp` at least requiring Sphinx 5.0. Upgrading the Furo theme may also improve the html output; we're pulling in almost two years worth of fixes here.
83fe22b
to
a81382e
Compare
Argh, forgot - fixed the commit messages now. |
PKG_CONFIG_PATH
Closes gh-460