Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds OKToMqtt bool to data #573

Merged
merged 2 commits into from
Sep 6, 2024
Merged

Adds OKToMqtt bool to data #573

merged 2 commits into from
Sep 6, 2024

Conversation

jp-bennett
Copy link
Contributor

Implements part of https://github.com/meshtastic/rfcs/blob/position-mqtt-privacy/rfcs/2024-08-30-position-privacy.md. This adds a bit to each data protobuf, indicating that the user consents to uploading their data to a public MQTT broker. Without this bit set to true, for the public channel, the firmware will refuse to upload packets to MQTT, and our MQTT broker will refuse to process the packets.

@GUVWAF
Copy link
Member

GUVWAF commented Sep 4, 2024

In general I'm okay, but it would thus also mean you have to update your firmware to be uplinked by MQTT gateways that have updated, or if you want to be picked up by the public MQTT?

And we need an accompanying setting for this, which should likely be automatically set when enabling MQTT.
Where do we do the setting? Don't think that the setting needs to be per channel, because only the default key will be picked up by MQTT nodes you don't know. So maybe LoRa config, as it's similar to "ignore MQTT"?

@ianmcorvidae
Copy link
Contributor

This is perhaps nitpicky, but I think we've used snake case usually in protobufs, and this is camelcased (I guess -- acronyms are funny with that, obviously). Probably not super important but nice to stay consistent.

@jp-bennett
Copy link
Contributor Author

@GUVWAF Yeah, still needs config. And agreed, not per channel.
@ianmcorvidae Yikes, good catch.

@jp-bennett jp-bennett marked this pull request as draft September 4, 2024 22:48
@jp-bennett jp-bennett marked this pull request as ready for review September 6, 2024 19:58
@caveman99 caveman99 merged commit 96b10c0 into master Sep 6, 2024
2 checks passed
@caveman99 caveman99 deleted the doNotMQTTMeBro branch September 6, 2024 20:26
@GUVWAF
Copy link
Member

GUVWAF commented Sep 6, 2024

it would thus also mean you have to update your firmware to be uplinked by MQTT gateways that have updated, or if you want to be picked up by the public MQTT

This is now not the case anymore, since it's made optional.

@jp-bennett
Copy link
Contributor Author

it would thus also mean you have to update your firmware to be uplinked by MQTT gateways that have updated, or if you want to be picked up by the public MQTT

This is now not the case anymore, since it's made optional.

My thought is to make it optional for a while, then flip it to blocking by default. Give people time to update, so we don't just nuke the MQTT server overnight.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants