-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fancy T-Deck / SenseCAP Indicator / unPhone / PICOmputer-S3 TFT screen #3259
base: master
Are you sure you want to change the base?
Conversation
d14151e
to
dcc11ff
Compare
2084055
to
d69edc2
Compare
b8a74c6
to
7dfeedc
Compare
Is possible to test on PICOmputer S3 ? I can send sample hardware. |
To Germany? Good. I can support it when I have the actual hardware available. |
worldwide, Germany is almost a neighbor, I'm from Slovakia. Picomputer use direct gpio matrix keyboard implemented by @caveman99 cpu is bpi-PicoW-S3 + RFM95 send my your postage address to [email protected] |
I am on the road right now but iirc the picomputer does only have 4MB flash. May be a tight fit. The TFT tracksenger may be a better fit. 8 MB is the min for an integrated device I would think. @mverch I have a picomputer prototype I can send you. Assuming @bobricius doesn't have a newer revision :-) |
That's also what I read on the ALI-Express page for the Banana-Pi. Should be fine. https://github.com/meshtastic/firmware/blob/tft-gui-work/boards/bpi_picow_esp32_s3.json#L28 |
This is looking great. I've been running it on hardware on and off for a few weeks and even in the current state I'd say it's made the T-Deck far more usable (as a standalone device) than it was before. I'm very impressed with the progress so far and look forward to seeing the improvements. Willing volunteer if you need anything tested or want specific feedback. |
Downloaded and installed latest CI artifacts. Will report back with any issues/bugs I find. |
[as usual latest commit] Sorry I was a bit absent. But: I flashed this PR to t-deck and t-echo and all fine. What I tested (basic):
The procedure for both:
Procedure for t-deck:
[I tested previous commits a bit more about the UI, so I kept this short] My opinion (but see also questions below): We should merge asap. This PR is a firmware support for the device-ui lib, and currently it seems more like checking master. From the pure technical point we solved the issue with RadioLibs. Not Tested, indeed. There is the comment from @fifieldt on main.cpp which we might need to resolve, My questions: If we merge this, how do we handle dev "tft" device-ui lib dependencies? The UI is going to get out resources: for example Bluetooth, or anyway something else. I will be happy with one version. I do not get a device with TFT if I am not able to pay the costs. I really hope we can merge this asap. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic!
Sorry the (*) above. |
Don't know how much my opinion matters here — I've only done a little work here and have only flashed/run on a T-Deck! But I'm definitely very supportive of merging to master to help coordinate dev efforts, I imagine that we can all be more helpful to @mverch67 who is doing some extraordinary work here! |
@j6k4m8 but you can approve the PR to show some love ;) |
can't argue with that :) |
Thanks @mariotti , @j6k4m8 . I've been trying to keep master up to date by cherry-picking anything from this branch that can go into master cleanly. Where I think we're at is device-ui (or at least parts of it, like the PacketAPI) need to go in before we'd be able to merge this. I'm not sure what the plan is for that, to be honest! |
@mverch67 you are invited to push the button and merge! I think everybody will thank you for this work! But do not get sad, you will see me in the UI repo :) |
Hoi @fifieldt the only issue I really have is how to handle the versions with UI or without. But I think this cannot be decided in this PR anyway. This is a requirement so that we can ask the right question ;) |
@mariotti please stop spamming the comment section of this PR. The core devs pretty much know how and when to merge this. Everytime you post here or 'approve this' all devs get an email. |
nothing to see here, yet. Work in progress