Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Adjust pie chart title to prevent cropping and added example for testing #6242

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

nourhenta
Copy link

@nourhenta nourhenta commented Jan 31, 2025

Description

Fixes #6232 - Pie Chart Title Gets Cut Off if Too Long

Solution

  • Dynamically adjusts the font size of the pie chart title to fit within the chart's width.
  • Updated the example.html to showcase the solution with a long title.

Testing

Tested with different title lengths to ensure proper resizing. Attached a screenshot of the result.

Notes

This solution avoids splitting the title into multiple lines and maintains the design aesthetics by scaling the font size.

Copy link

changeset-bot bot commented Jan 31, 2025

⚠️ No Changeset found

Latest commit: 086f291

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Jan 31, 2025

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit 086f291
🔍 Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/679d6755792ef70008f3bdd7
😎 Deploy Preview https://deploy-preview-6242--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

pkg-pr-new bot commented Jan 31, 2025

Open in Stackblitz

npm i https://pkg.pr.new/mermaid-js/mermaid@6242
npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/mermaid-zenuml@6242
npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/parser@6242
npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/layout-elk@6242

commit: 43b9e0a

Copy link

codecov bot commented Jan 31, 2025

Codecov Report

Attention: Patch coverage is 0% with 93 lines in your changes missing coverage. Please review.

Project coverage is 4.47%. Comparing base (e9e663f) to head (43b9e0a).
Report is 76 commits behind head on develop.

Files with missing lines Patch % Lines
packages/mermaid/src/diagrams/pie/pieRenderer.ts 0.00% 53 Missing ⚠️
...ges/mermaid/src/diagrams/class/classRenderer-v2.ts 0.00% 40 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           develop   #6242      +/-   ##
==========================================
- Coverage     4.47%   4.47%   -0.01%     
==========================================
  Files          385     384       -1     
  Lines        54180   54221      +41     
  Branches       598     623      +25     
==========================================
  Hits          2425    2425              
- Misses       51755   51796      +41     
Flag Coverage Δ
unit 4.47% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ges/mermaid/src/diagrams/class/classRenderer-v2.ts 0.00% <0.00%> (ø)
packages/mermaid/src/diagrams/pie/pieRenderer.ts 0.00% <0.00%> (ø)

... and 9 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pie Chart Title gets cut off if too long
1 participant