feat: Add certificate_manager_certificates variable for the https_proxy #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good news! Changes to the upstream module have rendered this PR unnecessary; you can create a proxy using a certificate map only, without needing to specify the certificate manager certificates as well. I have tested this and it works; I will be subsequently making a PR to our private repo reflecting this change. See the PR that made the change here. See the certificate map example here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've tested this, but only really with my use case. Further testing is warranted before submitting this for review upstream, especially with the Managed SSL and user-provided cert/key use-cases.