attempt to fix issue #354 and #355

due to some copy-and-pasto, `DynDefinedSpec._build_odxlinks()` unconditionally called itself and the `oid` parameter was missing from the fallback code for DTC decoding. (Be aware that the latter points towards an incomplete dataset.) Signed-off-by: Andreas Lauser <[email protected]> Signed-off-by: David Helwig <[email protected]>
mercedes-benz · Oct 28, 2024 · 3277e90 · 3277e90
1 parent e2a3010
commit 3277e90
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/odxtools/dtcdop.py b/odxtools/dtcdop.py
@@ -120,6 +120,7 @@ def decode_from_pdu(self, decode_state: DecodeState) -> ParameterValue:
         return DiagnosticTroubleCode(
             trouble_code=trouble_code,
             odx_id=cast(OdxLinkId, None),
+            oid=None,
             short_name=f'DTC_{trouble_code:06x}',
             long_name=None,
             description=None,

diff --git a/odxtools/dyndefinedspec.py b/odxtools/dyndefinedspec.py
@@ -163,8 +163,6 @@ def from_et(et_element: ElementTree.Element,
     def _build_odxlinks(self) -> Dict[OdxLinkId, Any]:
         result: Dict[OdxLinkId, Any] = {}
 
-        result.update(self._build_odxlinks())
-
         for didmi in self.dyn_id_def_mode_infos:
             result.update(didmi._build_odxlinks())