chore: set CGO_ENABLED=0 #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suzuki-shunsuke
requested review from
tcnksm,
drlau,
slewiskelly,
ryan-ph,
dtan4,
yanolab and
ryotafuwa-dev
as code owners
suzuki-shunsuke
commented
Jun 19, 2024
| @@ -1,3 +1,4 @@ | |||
| version: 2 | |||
There was a problem hiding this comment.
GoReleaser v2 requires version setting.
goreleaser check • only configurations files on version: 2 are supported, yours is version: 0 , please update your configuration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
(Write the change being made with this pull request)
Set
CGO_ENABLED=0when building hcledit.https://medium.com/@pengcheng1222/exploring-cgo-enabled-in-go-23cf5cf2fe88
WHY
(Write the motivation why you submit this pull request)
To resolve the issue.
Currently, hcledit depends on libc so hcledit doesn't work without libc.
By setting
CGO_ENABLED=0when building hcledit, hcledit works without libc.