Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support golang 1.18 or higher and type parameters #25

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kuzuha
Copy link

@kuzuha kuzuha commented Apr 18, 2022

Proposed Changes

  • Increase minimal supported version from Go 1.15 to Go 1.18
  • Bump up to v2
  • Support type parameters

Further Comments

Support Go 1.18 Type parameters.

Checklist

Please read the CLA (https://www.mercari.com/cla/) carefully before submitting your contribution to Mercari.

  • Under any circumstances, by submitting your contribution, you are deemed to accept and agree to be bound by the terms and conditions of the CLA.

@kuzuha kuzuha force-pushed the go-1.18-type-parameters branch 3 times, most recently from 9a5f5ce to 4e33c0d Compare April 19, 2022 03:54
@kuzuha
Copy link
Author

kuzuha commented Jun 20, 2022

@nguyengiabk how do you think about this?

@nguyengiabk
Copy link
Member

@kuzuha
Thank you so much for creating a PR.
And so sorry for late response.

Because generics are not production ready as stated here, please give me some time to consider 🙇
For now, could you please put v2 code into v2 sub-folder as recommended by https://go.dev/blog/v2-go-modules?

@kuzuha kuzuha force-pushed the go-1.18-type-parameters branch from 4e33c0d to d92f844 Compare June 21, 2022 05:23
@nguyengiabk
Copy link
Member

@kuzuha
Sorry for late response.
I've talked with some Go experts in our company, and we agreed that this refactoring has limited benefit (no clear reason to do) while reducing the readability. And one more important thing is Go Generics is still not production-ready.
So I will let this PR be open for a while.
We can take a look later when it makes more sense.

@agandreev
Copy link

@nguyengiabk Hello! Thank you so much for your library!!
What do you think about adding generics this time? It will be rather convenient for integrate breaker into grpc and http clients

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants