Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add availabilities to the REST API client #17

Merged
merged 7 commits into from
Apr 5, 2024

Conversation

m-timmermann
Copy link
Contributor

@m-timmermann m-timmermann commented Mar 18, 2024

This PR adds the availabilities to the REST API client.

See https://github.com/meplato/store.v3/issues/4041

Tested it locally and was able to receive availability information

* add Availabilities
@m-timmermann m-timmermann changed the title Add availabilities Add availabilities to the REST API client Mar 18, 2024
@m-timmermann m-timmermann marked this pull request as ready for review March 19, 2024 08:30
* fix - change post to put
* wip - removed key
Copy link
Member

@XoseRamon XoseRamon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the other services include unit tests, is there any reason why we skip them here?

@m-timmermann
Copy link
Contributor Author

Comitted the missing tests here.

…sue-4041

# Conflicts:
#	.github/workflows/release.yml
@m-timmermann m-timmermann requested a review from XoseRamon March 28, 2024 08:19
Copy link
Member

@XoseRamon XoseRamon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't test it, but it LGTM.

@m-timmermann m-timmermann merged commit 20caa0e into main Apr 5, 2024
6 checks passed
@m-timmermann m-timmermann deleted the add-availabilities.issue-4041 branch April 5, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants