Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .opam file to use with-dev-setup instead of with-test #38

Merged
merged 2 commits into from
Oct 29, 2024

Conversation

feihong
Copy link
Contributor

@feihong feihong commented Oct 25, 2024

package.json Outdated
@@ -2,7 +2,7 @@
"name": "melange-opam-template",
"scripts": {
"preinstall-opam": "opam update",
"install-opam": "opam install -y . --deps-only --with-test",
"install-opam": "opam install -y . --deps-only --with-test --with-dev-setup",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jchavarri I kept --with-test, although it isn't really needed anymore. Should I just remove it?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, please.

Copy link
Contributor Author

@feihong feihong Oct 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, can you merge it? I don't have write access.

@jchavarri
Copy link
Member

CI is failing:

opam: unknown option `--with-dev-setup', did you mean `-w' ?

we should fix this before merging.

@feihong
Copy link
Contributor Author

feihong commented Oct 29, 2024

@jchavarri Fixed by upgrading ocaml/setup-ocaml action from v2 to v3 so that it uses opam 2.2: 2d2b43c

@jchavarri
Copy link
Member

Thanks!

@jchavarri jchavarri merged commit a2b9b08 into melange-re:main Oct 29, 2024
2 checks passed
@feihong feihong deleted the with-dev-setup branch October 29, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants