-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update .opam file to use with-dev-setup instead of with-test #38
Conversation
package.json
Outdated
@@ -2,7 +2,7 @@ | |||
"name": "melange-opam-template", | |||
"scripts": { | |||
"preinstall-opam": "opam update", | |||
"install-opam": "opam install -y . --deps-only --with-test", | |||
"install-opam": "opam install -y . --deps-only --with-test --with-dev-setup", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jchavarri I kept --with-test
, although it isn't really needed anymore. Should I just remove it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, please.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed, can you merge it? I don't have write access.
4d5861c
to
48669b6
Compare
CI is failing:
we should fix this before merging. |
@jchavarri Fixed by upgrading ocaml/setup-ocaml action from v2 to v3 so that it uses opam 2.2: 2d2b43c |
Thanks! |
Addressing https://github.com/melange-re/melange-re.github.io/pull/200/files#r1811990250