Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TLC-151:Enabled the 'Death information' section in the registration form #9

Merged
merged 7 commits into from
Jul 19, 2024
Merged

TLC-151:Enabled the 'Death information' section in the registration form #9

merged 7 commits into from
Jul 19, 2024

Conversation

kazlaw
Copy link
Contributor

@kazlaw kazlaw commented Jul 8, 2024 •
edited
Loading

Ticket here: https://mekomsolutions.atlassian.net/browse/TLC-151

Initial test below:

Screencast.from.08-07-24.09.26.11.webm

@kazlaw kazlaw marked this pull request as draft July 17, 2024 12:03
@kazlaw kazlaw marked this pull request as ready for review July 17, 2024 13:45
@kazlaw
Copy link
Contributor Author

kazlaw commented Jul 17, 2024 •
edited
Loading

Screencast.from.17-07-24.16.15.32.webm

@kazlaw kazlaw requested review from rbuisson and Ruhanga July 18, 2024 07:38
Ruhanga
Ruhanga reviewed Jul 18, 2024
View reviewed changes
Copy link
Member

@Ruhanga Ruhanga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build fails @kazlaw. Is there no concept already existing for the failing line?
Screenshot 2024-07-18 at 11 06 50

@kazlaw
Copy link
Contributor Author

kazlaw commented Jul 18, 2024 •
edited
Loading

The build fails @kazlaw. Is there no concept already existing for the failing line? Screenshot 2024-07-18 at 11 06 50

I missed it when making this commit here:a0fc2a8 They already exist at the Haiti level so its simply a UUID swap and deleting of the duplicate

@kazlaw
Copy link
Contributor Author

kazlaw commented Jul 18, 2024

Screencast.from.18-07-24.12.59.46.webm

This should be good to go.

@kazlaw kazlaw requested a review from Ruhanga July 18, 2024 10:01
Ruhanga
Ruhanga approved these changes Jul 18, 2024
View reviewed changes
Copy link
Member

@Ruhanga Ruhanga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kazlaw
Copy link
Contributor Author

kazlaw commented Jul 18, 2024

@Ruhanga please merge I am unable to

@kazlaw kazlaw requested a review from Ruhanga July 18, 2024 11:16
@Ruhanga Ruhanga merged commit 6ed6cd5 into mekomsolutions:main Jul 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbuisson rbuisson Awaiting requested review from rbuisson

@Ruhanga Ruhanga Awaiting requested review from Ruhanga

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kazlaw @Ruhanga