Refactor lib/meilisearch.rb
#379
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #379 +/- ##
==========================================
+ Coverage 88.96% 89.72% +0.75%
==========================================
Files 13 16 +3
Lines 761 788 +27
==========================================
+ Hits 677 707 +30
+ Misses 84 81 -3 ☔ View full report in Codecov by Sentry. |
ellnix
force-pushed
the
refactor-lib-meilisearch
branch
from
7da3be4 to
3991366
Compare
I cannot figure out why this was ever created, all tests pass with this change, it feels to me like this is just a roundabout way of shoving `self` into the hash. If there's a distinction between this logic and `self` please let me know.
This should highlight the difference between these settings that concern the index and meilisearch_options which are rails-specific.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Related issue
Fixes #348
See related issue.