Allow configuring the site directory #131
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the web directory is set to
/public, with no option to change this. This adds a new environment value that allows overwriting this option.For example, we have a Laravel package (so not an app), but within it we have a playground. This playground is an app to visually test the package. Thus we need to update the directory to
/playground/public, which we currently do with an artisan command in the deploy script.I have yet to test this, but I think this value should be used for the document_root, not where the project itself is located. We currently use this endpoint: https://forge.laravel.com/api-documentation#update-site. And that works as intended, so I think the new site creation should also work.
I can set this PR to draft until I've had a chance to test/verify, if you prefer that :)