-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
run tests on GitHub actions #805
base: develop
Are you sure you want to change the base?
Conversation
dmou
commented
Jun 12, 2021
- runs unit and functional tests in parallel in github actions
- removes travis
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wooo now I can see the tests output! Looks like all are passing!
Just two things:
- Looks like the Slack notification didn't work: https://github.com/meedan/check-api/pull/805/checks?check_run_id=2807491900#step:2:5
- Looks like Code Climate didn't receive the coverage report: https://codeclimate.com/repos/58bdc058359261025a0020fa/settings/test_reporter
abd653d
to
d18b38b
Compare
and try not rebuilding docker-compose up
and sudo install aws?
f43891e
to
9dfa7f0
Compare
@dmou I know it's been awhile, but do you have a sense for what this PR would need to get merged? remaining to-dos etc? we discussed in retro today how just having test runs in github actions would speed things up since things are getting stuck waiting with the 5 travis runners, so I'm curious about what's left here |
Is this PR still relevant? |
@caiosba honestly probably still good to reference for dockerfile consolidation efforts tbh, wish I could turn it into a draft 🤔 we can close it though, the commits will still exist :p |
You can turn it back into a draft :) OK, let's keep it for visibility until we have a ticket scheduled that we can use to reference this work... otherwise we'll forget it exists. |