Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug – CV2-5913 – Cannot update a new record #2173

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

Bug – CV2-5913 – Cannot update a new record #2173

wants to merge 1 commit into from

Conversation

vasconsaurus
Copy link
Contributor

Description

We have a ActiveRecord::ActiveRecordError: cannot update a new record that is related to an error we saw on Zapier.

References: CV2-5913

How has this been tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can verify the changes. Please describe whether or not you implemented automated tests.

Things to pay attention to during code review

Please describe parts of the change that require extra attention during code review, for example:

  • File FFFF, line LL: This refactoring does this and this. Is it consistent with how it’s implemented elsewhere?
  • Etc.

Checklist

  • I have performed a self-review of my own code
  • I have added unit and feature tests, if the PR implements a new feature or otherwise would benefit from additional testing
  • I have added regression tests, if the PR fixes a bug
  • I have added logging, exception reporting, and custom tracing with any additional information required for debugging
  • I considered secure coding practices when writing this code. Any security concerns are noted above.
  • I have commented my code in hard-to-understand areas, if any
  • I have made needed changes to the README
  • My changes generate no new warnings
  • If I added a third party module, I included a rationale for doing so and followed our current guidelines

@vasconsaurus
WIP: add test
8a4d1ee 
Still a work in progress so I kept the three tests I was testing – for now:
- Two are just attempts to reproduce what I was able to do manually, so:
   - Create a Link Media related to a FactCheck
   - Try to import an item with the same link as original_claim, in the
   same language
   - They return a success. But the dbid for project_media is nil,
   and claim_description is also nil, but a full_url for the
   project_media is returned.
- The other test I tried to see if I could force it to maybe error the same
way by creating the ProjectMedia with original_claim
   - It errors as expected, so I plan to remove it
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caiosba caiosba Awaiting requested review from caiosba caiosba will be requested when the pull request is marked ready for review caiosba is a code owner

@melsawy melsawy Awaiting requested review from melsawy melsawy will be requested when the pull request is marked ready for review melsawy is a code owner

@DGaffney DGaffney Awaiting requested review from DGaffney DGaffney will be requested when the pull request is marked ready for review DGaffney is a code owner

@jayjay-w jayjay-w Awaiting requested review from jayjay-w jayjay-w will be requested when the pull request is marked ready for review jayjay-w is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@vasconsaurus