Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: parameter handling in migration script #11

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

shahednasser
Copy link
Member

In the documentation, it's mentioned that the migration script can be invoked to handle single files as the following:

npm run migrate:contentful --file contentful-migrations/rich-text.js

However, this doesn't work as the script that handles the migration does not care about arguments passed to the command.

This new change will allow us to pass parameters to the script as follows:

npm run migrate:contentful contentful-migrations/rich-text.js

This can be very helpful when customizing the contentful integration by adding content models. At the moment, I'll change the documentation to include details of creating the migration files separate from the integration. If this gets merged I'll reflect it in the documentation.

@shahednasser shahednasser requested a review from srindom July 21, 2022 16:24
@changeset-bot
Copy link

changeset-bot bot commented Jul 21, 2022

⚠️ No Changeset found

Latest commit: 447e400

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant