Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SharedEscrow] Enable close shared escrow pool except for fulfill buy #88

Closed
wants to merge 3 commits into from
Closed

[SharedEscrow] Enable close shared escrow pool except for fulfill buy #88

wants to merge 3 commits into from

Conversation

JeremyLi28
Copy link
Contributor

@JeremyLi28 JeremyLi28 commented Mar 14, 2024 •
edited
Loading

Shared escrow pool should be able to be closed as other pools, with the exception that when fulfill buy and sharedEscrowCount > 0

nothing0012
nothing0012 approved these changes Mar 14, 2024
View reviewed changes
Copy link
Contributor

@nothing0012 nothing0012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nothing0012
Copy link
Contributor

temp close this in favor of client side changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nothing0012 nothing0012 nothing0012 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JeremyLi28 @nothing0012