Add Blue Star award and refactor #64
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
March 18, 2023 15:18
… spec file to pass all tests
…' -> 'NormalStrategy'. Renamed 'AwardQualityUpdateStrategy' -> 'AwardQualityUpdateManager'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the Blue Star award and refactors legacy the code entirely and reimplements the code using the 'Strategy' Design Pattern. Html docs and a UML Diagram were added for documentation in the 'docs' folder. Some additional test cases were also appended to the 'update_quality_spec' file.
Algorithms for updating quality are now stored in 'Strategy' classes which are invoked by a Strategy Class Manager. The 'update_quality' function now simply invokes the Manager 'update' class function. The updating algorithms themselves were kept as close to original as possible to maintain intent but modified for better adherence to business rules.