Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deterministic cfbs #54

Merged
merged 3 commits into from
Jan 21, 2025
Merged

Deterministic cfbs #54

merged 3 commits into from
Jan 21, 2025

Conversation

sftse
Copy link
Contributor

@sftse sftse commented Apr 18, 2024

I need a way to reliably generate deterministic cfb files. It seems it suffices to be able to override the timestamps.

Copy link
Owner

@mdsteele mdsteele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, these seem like good methods to add.

src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
@sftse
Copy link
Contributor Author

sftse commented May 21, 2024

This is a bit beside the point of this PR, but I happen to notice that the timestamps coming from Entry::created and Entry::modified are nonsensical on streams since those timestamps are all zeroes. Should these functions perhaps return Option<SystemTime>?

@sftse sftse requested a review from mdsteele May 21, 2024 10:53
@sftse
Copy link
Contributor Author

sftse commented Jan 16, 2025

@mdsteele
The comments you raised were addressed, is there anything else to be done?

@mdsteele mdsteele merged commit 30668e9 into mdsteele:master Jan 21, 2025
4 checks passed
@mdsteele
Copy link
Owner

Thanks! (Sorry for the long delay, this had fallen off my radar.)

@sftse sftse deleted the deterministic branch January 21, 2025 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants