feat: signature (transaction) types #15
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| export type SignatureType = { | ||
| prefixByte: number; | ||
| description: string; | ||
| // The data that is RLP encoded and signed to generate a signed transaction. | ||
| signedData: string[] | undefined; | ||
| // Some signature types are used to sign transactions, others are used to sign data. | ||
| signs: 'transaction' | 'data' | undefined; | ||
| references: string[]; | ||
| notes?: string[]; | ||
| }; |
There was a problem hiding this comment.
Would include hardforks: []string here, protocol specs change. And then when importing L1 mainnet tx types in L2 support lists, filter by supported L1 forks. When L1 updates, not all L2s update immediately. E.g. 1559 wasn't on L2 everywhere the instant it was a mainnet L1 tx type.
There was a problem hiding this comment.
Yea I was thinking about this too. Since it applies to other things (e.g. opcodes) I'm going to add this more broadly in a future PR. Now tracking in #16
| const isEqual = JSON.stringify(baseSigType) === JSON.stringify(targetSigType); | ||
| const showSigType = !isEqual || !onlyShowDiff; | ||
|
|
||
| return ( |
There was a problem hiding this comment.
Would be nice to show the hardfork range info here.
| references: [ | ||
| txTypeDocs, | ||
| 'https://github.com/OffchainLabs/go-ethereum/blob/master/core/types/transaction.go#L53', | ||
| 'https://github.com/OffchainLabs/go-ethereum/blob/master/core/types/arb_types.go#L387-L390', |
There was a problem hiding this comment.
These line numbers are already broken, the file changed yesterday. I recommend pinning links to a commit or release tag.
There was a problem hiding this comment.
Heh was wondering if these files were stable enough to link to master directly to avoid clicking a permalink and having to wonder if that link is actually up to date. Seems the answer is no, so back to permalinks 😅
| import { SignatureType } from '@/chains'; | ||
| import { signatureTypes as mainnetSignatureTypes } from '@/chains/mainnet/signatureTypes'; | ||
|
|
||
| const txTypeDocs = 'https://developer.arbitrum.io/arbos/geth#transaction-types'; |
There was a problem hiding this comment.
Thought I noticed a gap, and there is indeed a tx type 103 (0x067) that was removed but existed previously. Not sure if it ended up in a mainnet deployment. It was the "ArbitrumWrappedTxType". Worth documenting maybe?
There was a problem hiding this comment.
Ah great find, do you have a link? Searched their issues/PRs/codebase for that name and number but didn't find it
For predeploys there's deprecated: bool field, seems worth adding the same for transaction types.
Arguably type 0 transactions should be considered deprecated too, since they're almost always worse. Only (contrived) exception I can think of is you have a bit less calldata to post on L1 with a type 0 tx since there's less gas params to specify, so it may be cheaper in some instances (e.g. sweeping an account where you don't care about the refund)
Adds EIP-2718 transaction and signature types for mainnet, arbitrum, and optimism, along with a basic rendering of their diff. Showing more detailed info in the diff + style improvements will come in a future PR.
One thing currently implied is that both arbitrum and optimism both consider prefix byte 0x03 reserved and will not use it. Optimism's spec for the Deposited Transaction type suggests they'll avoid using that prefix byte:
I couldn't explicitly find anything similar for Arbitrum, but given that their new transaction types also use high identifiers, I imagine they also don't plan to use it