Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zh-cn: update the translation of "HTTP Overview" #21762

Merged
merged 2 commits into from
Jun 24, 2024
Merged

zh-cn: update the translation of "HTTP Overview" #21762

merged 2 commits into from
Jun 24, 2024

Conversation

yin1999
Copy link
Member

@yin1999 yin1999 commented Jun 20, 2024

Description

update the translation of "HTTP Overview"

Related issues and pull requests

The images have been replaced in en-US: mdn/content#34251

@yin1999 yin1999 requested a review from a team as a code owner June 20, 2024 06:57
@yin1999 yin1999 requested review from jasonren0403 and removed request for a team June 20, 2024 06:57
@github-actions github-actions bot added the l10n-zh Issues related to Chinese content. label Jun 20, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 20, 2024 •
edited
Loading

Preview URLs

Flaws (5)

URL: /zh-CN/docs/Web/HTTP/Overview
Title: HTTP 概述
Flaw count: 5

  • images:
    • External image URL
    • External image URL
    • External image URL
    • External image URL
    • External image URL
External URLs (2)

URL: /zh-CN/docs/Web/HTTP/Overview
Title: HTTP 概述

(comment last updated: 2024-06-21 12:34:22)

@jasonren0403
Copy link
Contributor

seems that images from shared assets don't load in preview server 🤔

image

jasonren0403
jasonren0403 reviewed Jun 21, 2024
View reviewed changes
Copy link
Contributor

@jasonren0403 jasonren0403 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some suggestions

files/zh-cn/web/http/overview/index.md Outdated Show resolved Hide resolved
files/zh-cn/web/http/overview/index.md Outdated Show resolved Hide resolved
files/zh-cn/web/http/overview/index.md Outdated Show resolved Hide resolved
files/zh-cn/web/http/overview/index.md Outdated Show resolved Hide resolved
files/zh-cn/web/http/overview/index.md Outdated Show resolved Hide resolved
files/zh-cn/web/http/overview/index.md Outdated Show resolved Hide resolved
files/zh-cn/web/http/overview/index.md Outdated Show resolved Hide resolved
files/zh-cn/web/http/overview/index.md Outdated Show resolved Hide resolved
files/zh-cn/web/http/overview/index.md Outdated Show resolved Hide resolved
files/zh-cn/web/http/overview/index.md Outdated Show resolved Hide resolved
@yin1999
Copy link
Member Author

yin1999 commented Jun 21, 2024

seems that images from shared assets don't load in preview server 🤔

image

Caused by csp policy. It might be fixed in future.

@yin1999 yin1999 requested a review from jasonren0403 June 21, 2024 12:34
jasonren0403
jasonren0403 approved these changes Jun 24, 2024
View reviewed changes
Copy link
Contributor

@jasonren0403 jasonren0403 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thank you @yin1999

@jasonren0403 jasonren0403 merged commit 75d5085 into mdn:main Jun 24, 2024
7 checks passed
@yin1999 yin1999 deleted the http-overview branch July 17, 2024 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonren0403 jasonren0403 jasonren0403 approved these changes

Assignees
No one assigned
Labels
l10n-zh Issues related to Chinese content.
Projects
MDN translated-content l10n-zh
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yin1999 @jasonren0403