Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add mdn.svg #30

Merged
merged 4 commits into from
Nov 8, 2024
Merged

feat: Add mdn.svg #30

merged 4 commits into from
Nov 8, 2024

Conversation

bsmth
Copy link
Member

@bsmth bsmth commented Nov 5, 2024

Adding an asset we use for existing examples

@bsmth bsmth requested a review from a team as a code owner November 5, 2024 16:51
@bsmth bsmth requested a review from pepelsbey November 5, 2024 16:51
Copy link
Member

@pepelsbey pepelsbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be safe to optimize the image (just dropped it to SVGOMG), but it’s also called MDN.svg, and most of the files are lowercase. I wonder if we should keep this one lowercase, too. Would it be too problematic to change all demos to lowercase?

images/examples/MDN.svg Outdated Show resolved Hide resolved
@bsmth
Copy link
Member Author

bsmth commented Nov 7, 2024

I wonder if we should keep this one lowercase, too. Would it be too problematic to change all demos to lowercase?

No objections to that, let's lowercase it. It's not deployed here yet, so it's not used anywhere. It shouldn't be a problem, so let's go ahead and rename

@bsmth bsmth changed the title feat: Add MDN.svg feat: Add mdn.svg Nov 7, 2024
@pepelsbey pepelsbey merged commit a5a65a6 into main Nov 8, 2024
@pepelsbey pepelsbey deleted the mdn-logo branch November 8, 2024 07:56
@pepelsbey
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants