Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ::details-content example. #2874

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lukewarlow
Copy link
Contributor

Description

Adds an example for the new ::details-content pseudo element.

Motivation

To showcase this on the MDN page.

Additional details

https://drafts.csswg.org/css-pseudo/#details-content-pseudo

Related issues and pull requests

@lukewarlow lukewarlow requested a review from a team as a code owner December 6, 2024 11:54
@lukewarlow lukewarlow requested review from chrisdavidmills and removed request for a team December 6, 2024 11:54
@lukewarlow
Copy link
Contributor Author

lukewarlow commented Dec 6, 2024

Linter doesn't seem aware of this new pseudo element. PR to update stylelint stylelint/stylelint#8174

Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @lukewarlow, thanks for submitting the new example; looks good to me.

I'll approve this, but I'm assuming we shouldn't (or can't) merge it until the new stylelint package is picked up by our code?

@lukewarlow
Copy link
Contributor Author

@chrisdavidmills we can either wait or I can update the stylelint config to ignore the error for this specific pseudo element.

@chrisdavidmills
Copy link
Contributor

@chrisdavidmills we can either wait or I can update the stylelint config to ignore the error for this specific pseudo element.

@lukewarlow I'm happy with either approach. Take your pick.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants