Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(css): improve contrast of margin-block #2666

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

dkdk225
Copy link
Contributor

@dkdk225 dkdk225 commented Nov 18, 2023

Description

Make the text inside the rows at margin-block-start and margin-block-end examples white.

Motivation

To prevent the text from becoming black color at light mode causing contrast issues

Related issues and pull requests

#2054

@dkdk225 dkdk225 requested a review from a team as a code owner November 18, 2023 13:09
@dkdk225 dkdk225 requested review from estelle and removed request for a team November 18, 2023 13:09
Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🎉

@estelle estelle merged commit 0df7a29 into mdn:main Nov 29, 2023
5 checks passed
Copy link

Congratulations on your first merged pull request. 🎉 Thank you for your contribution! Did you know we have a project board with high-impact contribution opportunities? We look forward to your next contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants