Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(css): fix contrast of 9 css examples #2469

Merged
merged 17 commits into from
Mar 3, 2023
Merged

fix(css): fix contrast of 9 css examples #2469

merged 17 commits into from
Mar 3, 2023

Conversation

rohini-ranjanR
Copy link
Contributor

Description

This PR improves the contrast of the following examples:

Motivation

Additional details

Related issues and pull requests

Relates #2054

Copy link
Member

@NiedziolkaMichal NiedziolkaMichal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good job, thank you. There are still 3 small things that need to be changed:

  • In list-style-type example, the text @counter-style has a poor contrast in the dark mode.
  • In pointer-events example, the text example link also has poor contrast.
  • In the pointer-events, could you change the white color of the text SVG to be set with fill rather than stroke? It will be more legible.

@NiedziolkaMichal
Copy link
Member

@rohini-ranjanR It's not a good idea to use style attribute. In both cases, it's best to use a separate class or use tag attribute. Could you also keep those colors consistent across the examples?

Copy link
Member

@NiedziolkaMichal NiedziolkaMichal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The shade of green you have chosen doesn't meet contrast requirements now, #009e5f will be better. Can you also run fix:css, so the empty space after } is deleted?

@NiedziolkaMichal NiedziolkaMichal merged commit f32a584 into mdn:main Mar 3, 2023
@rohini-ranjanR rohini-ranjanR deleted the rohini-ranjanR-improve-contrast branch March 4, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants