-
Notifications
You must be signed in to change notification settings - Fork 518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(css): fix contrast of 9 css examples #2469
fix(css): fix contrast of 9 css examples #2469
Conversation
this commit improves the contrast of margin-block, margin-block-start, and margin-block-end
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good job, thank you. There are still 3 small things that need to be changed:
- In
list-style-type
example, the text@counter-style
has a poor contrast in the dark mode. - In
pointer-events
example, the textexample link
also has poor contrast. - In the
pointer-events
, could you change the white color of the textSVG
to be set withfill
rather thanstroke
? It will be more legible.
@rohini-ranjanR It's not a good idea to use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The shade of green you have chosen doesn't meet contrast requirements now, #009e5f
will be better. Can you also run fix:css
, so the empty space after }
is deleted?
Description
This PR improves the contrast of the following examples:
Motivation
Additional details
Related issues and pull requests
Relates #2054