Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rtcdatachannel binarytype fix #37859

Merged
merged 2 commits into from
Jan 29, 2025

Conversation

gagan-bhullar-tech
Copy link
Contributor

PR fixes #37848

@gagan-bhullar-tech gagan-bhullar-tech requested a review from a team as a code owner January 28, 2025 22:16
@gagan-bhullar-tech gagan-bhullar-tech requested review from sideshowbarker and removed request for a team January 28, 2025 22:16
@github-actions github-actions bot added Content:WebAPI Web API docs size/xs [PR only] 0-5 LoC changed labels Jan 28, 2025
Copy link
Contributor

github-actions bot commented Jan 28, 2025

Preview URLs

(comment last updated: 2025-01-28 23:50:17)

@nikwen
Copy link

nikwen commented Jan 28, 2025

Thanks for the PR! There's another mention of the default value here: https://developer.mozilla.org/en-US/docs/Web/API/RTCDataChannel

(Thanks to @Josh-Cena who discovered it in the linked issue.)

@gagan-bhullar-tech
Copy link
Contributor Author

@nikwen updated PR.

@Josh-Cena Josh-Cena merged commit ea27e60 into mdn:main Jan 29, 2025
8 checks passed
@nikwen
Copy link

nikwen commented Jan 29, 2025

Thanks, @gagan-bhullar-tech and @Josh-Cena!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:WebAPI Web API docs size/xs [PR only] 0-5 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect default value for RTCDataChannel.binaryType
3 participants