Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replaced cool looking box link with inline code blocks #37522

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

dletorey
Copy link
Contributor

@dletorey dletorey commented Jan 6, 2025

Description

  • replaced the link to the html & css files with inline code blocks
  • this is a copy of PR #37263 but respects the new page structures

Motivation

  • Helping @bsmth with the migration of examples into content

@dletorey dletorey requested a review from a team as a code owner January 6, 2025 15:03
@dletorey dletorey requested review from chrisdavidmills and bsmth and removed request for a team and chrisdavidmills January 6, 2025 15:03
@github-actions github-actions bot added the size/m [PR only] 51-500 LoC changed label Jan 6, 2025
Copy link
Contributor

github-actions bot commented Jan 6, 2025

Preview URLs

Flaws (251)

URL: /en-US/docs/Learn_web_development/Core/Styling_basics/Cool-looking_box
Title: Challenge: A cool-looking box
Flaw count: 251

  • macros:
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/Getting_started_with_the_web
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/Getting_started_with_the_web/Installing_basic_software
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/Getting_started_with_the_web/What_will_your_website_look_like
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/Getting_started_with_the_web/Dealing_with_files
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/Getting_started_with_the_web/HTML_basics
    • and 246 more flaws omitted

Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@bsmth bsmth merged commit ca58132 into mdn:main Jan 6, 2025
7 checks passed
@dletorey dletorey deleted the new-cool-looking-box branch January 6, 2025 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/m [PR only] 51-500 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants