Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove VTTCue.line link #37486

Merged
merged 7 commits into from
Jan 6, 2025
Merged

Remove VTTCue.line link #37486

merged 7 commits into from
Jan 6, 2025

Conversation

denes-sebestyen
Copy link
Contributor

Removed VTTCue.line link

Description

I removed the link to the VTTCue.line and cleared up the description of lineAlign

Motivation

The link to VTTCue.line was confusing as the lineAlign is not dependent on line, it is an other positioning attribute.

Additional details

A future extension of the description could be a link to the Cue settings / align

Related issues and pull requests

Some examples missed the :: prefix before the cue CSS selectors, and that does not work for video cues.
Added them.
@denes-sebestyen denes-sebestyen requested a review from a team as a code owner January 3, 2025 20:22
@denes-sebestyen denes-sebestyen requested review from bsmth and removed request for a team January 3, 2025 20:22
@github-actions github-actions bot added Content:WebAPI Web API docs size/xs [PR only] 0-5 LoC changed labels Jan 3, 2025
Copy link
Contributor

github-actions bot commented Jan 3, 2025

Preview URLs

(comment last updated: 2025-01-03 22:29:42)

Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@bsmth bsmth merged commit c198131 into mdn:main Jan 6, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:WebAPI Web API docs size/xs [PR only] 0-5 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants