Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inaccurate function name in example code #37279

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Conversation

Zenkoina
Copy link
Contributor

Description

Change the function name for unregistering a periodic sync from registerPeriodicSync to unregisterPeriodicSync.

Motivation

The function name registerPeriodicSync was likely an oversight as the function does the opposite.

@Zenkoina Zenkoina requested a review from a team as a code owner December 19, 2024 15:08
@Zenkoina Zenkoina requested review from hamishwillee and removed request for a team December 19, 2024 15:08
@github-actions github-actions bot added Content:PWA Progressive Web Apps content size/xs [PR only] 0-5 LoC changed labels Dec 19, 2024
Copy link
Collaborator

@hamishwillee hamishwillee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much - good catch.

@hamishwillee hamishwillee merged commit b3f8fa5 into mdn:main Dec 19, 2024
7 checks passed
Copy link
Contributor

@Zenkoina Zenkoina deleted the patch-1 branch December 20, 2024 13:30
allan-bonadio pushed a commit to allan-bonadio/content that referenced this pull request Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:PWA Progressive Web Apps content size/xs [PR only] 0-5 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants