Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(css): rephrase vriable font example proes #37258

Merged
merged 3 commits into from
Dec 19, 2024

Conversation

OnkarRuikar
Copy link
Contributor

When read out of context, the lines are hard to grasp. Adding more details will certainly help.

@OnkarRuikar OnkarRuikar requested a review from a team as a code owner December 18, 2024 07:32
@OnkarRuikar OnkarRuikar requested review from chrisdavidmills and removed request for a team December 18, 2024 07:32
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs size/s [PR only] 6-50 LoC changed labels Dec 18, 2024
Copy link
Contributor

github-actions bot commented Dec 18, 2024

Preview URLs

(comment last updated: 2024-12-19 02:40:33)

Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@OnkarRuikar a couple of suggestions to make the wording a bit clearer, but overall looking good.

Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; let's do this!

@chrisdavidmills chrisdavidmills merged commit 8013290 into mdn:main Dec 19, 2024
8 checks passed
@OnkarRuikar OnkarRuikar deleted the css_variable_font_guide branch December 20, 2024 05:10
allan-bonadio pushed a commit to allan-bonadio/content that referenced this pull request Dec 25, 2024
* fix(css): rephrase vriable font example proes

* Update files/en-us/web/css/css_fonts/variable_fonts_guide/index.md

* Apply suggestions from code review

Co-authored-by: Chris Mills <[email protected]>

---------

Co-authored-by: Chris Mills <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:CSS Cascading Style Sheets docs size/s [PR only] 6-50 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Variable Fonts example code not matching description
2 participants