Add docs for {NavigateEvent,PopStateEvent}.hasUAVisualTransition
#36705
+134
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Content:WebAPI
skyclouds2001
requested review from
sideshowbarker
and removed request for
a team
skyclouds2001
commented
Nov 9, 2024
skyclouds2001
commented
Nov 9, 2024
skyclouds2001
force-pushed
the
NavigateEvent-PopStateEvent-hasUAVisualTransition
branch
from
7ca90f7 to
b65b486
Compare
skyclouds2001
force-pushed
the
NavigateEvent-PopStateEvent-hasUAVisualTransition
branch
from
b65b486 to
98f3c4b
Compare
skyclouds2001
force-pushed
the
NavigateEvent-PopStateEvent-hasUAVisualTransition
branch
from
98f3c4b to
b918c05
Compare
bsmth
reviewed
Jan 6, 2025
files/en-us/web/api/navigateevent/hasuavisualtransition/index.md
Outdated
Show resolved
Hide resolved
bsmth
reviewed
Jan 6, 2025
files/en-us/web/api/navigateevent/hasuavisualtransition/index.md
Outdated
Show resolved
Hide resolved
bsmth
reviewed
Jan 6, 2025
bsmth
reviewed
Jan 6, 2025
files/en-us/web/api/popstateevent/hasuavisualtransition/index.md
Outdated
Show resolved
Hide resolved
bsmth
reviewed
Jan 6, 2025
files/en-us/web/api/popstateevent/hasuavisualtransition/index.md
Outdated
Show resolved
Hide resolved
bsmth
reviewed
Jan 6, 2025
bsmth
reviewed
Jan 6, 2025
| ```js | ||
| window.addEventListener("popstate", (event) => { | ||
| // Fetch the new content | ||
| const newContent = await fetchNewContent(event.destination.url, { |
There was a problem hiding this comment.
Is the origin important here given the event type? The same-origin clarification was good above.
There was a problem hiding this comment.
I mean is this relevant for popstate:
if (!event.canIntercept) {
return;
}
There was a problem hiding this comment.
yes, I've fixed the examplecode, as the event type is PopStateEvent, which only supports state and hasUAVisualTransition properties
Co-authored-by: Brian Smith <[email protected]>
skyclouds2001
commented
Jan 6, 2025
files/en-us/web/api/popstateevent/hasuavisualtransition/index.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Brian Smith <[email protected]>
skyclouds2001
commented
Jan 6, 2025
files/en-us/web/api/popstateevent/hasuavisualtransition/index.md
Outdated
Show resolved
Hide resolved
bsmth
approved these changes
Jan 6, 2025
|
Thank you, merging now 👍🏻 |
skyclouds2001
deleted the
NavigateEvent-PopStateEvent-hasUAVisualTransition
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://html.spec.whatwg.org/multipage/nav-history-apis.html#dom-navigateevent-hasuavisualtransition
https://html.spec.whatwg.org/multipage/nav-history-apis.html#dom-popstateevent-hasuavisualtransition
https://chromestatus.com/feature/5204831477694464
https://developer.chrome.com/docs/web-platform/view-transitions/same-document?hl=zh-cn
Motivation
Additional details
Related issues and pull requests