Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): Separate workflows by workflow trigger, rename config files #31745

Closed
wants to merge 1 commit into from

Conversation

bsmth
Copy link
Member

@bsmth bsmth commented Jan 16, 2024

The "Label PRs by size" workflow relies on the pull_request event type, but we're using pull_request_target, so the job is successful, but does nothing:

Event is not a pull request, doing nothing

Instead of interleaving the event types:

on:
  - pull_request
  - pull_request_target

jobs:
  label:
    steps:
      - if: github.event_name == 'pull_request_target'
# etc.

I'm putting these two jobs in their own files for simplicity.

@bsmth bsmth requested a review from a team as a code owner January 16, 2024 15:25
@github-actions github-actions bot added the system [PR only] Infrastructure and configuration for the project label Jan 16, 2024
@bsmth bsmth marked this pull request as draft January 16, 2024 21:51
@bsmth bsmth closed this Jan 17, 2024
@bsmth bsmth deleted the ci-separate-workflows branch January 17, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
system [PR only] Infrastructure and configuration for the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant