Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct descriptions of the asynchronous iterator methods on FileSystemDirectoryHandle #29012

Merged
merged 8 commits into from
Nov 6, 2023

Conversation

BSPR0002
Copy link
Contributor

@BSPR0002 BSPR0002 commented Sep 9, 2023

Description

Correct descriptions of the asynchronous iterator methods on FileSystemDirectoryHandle.

Motivation

FileSystemDirectoryHandle: keys()
FileSystemDirectoryHandle: values()
FileSystemDirectoryHandle: entries()

Related issues and pull requests

Fixes #25876

@BSPR0002 BSPR0002 requested a review from a team as a code owner September 9, 2023 01:47
@BSPR0002 BSPR0002 requested review from Elchi3 and removed request for a team September 9, 2023 01:47
@github-actions github-actions bot added the Content:WebAPI Web API docs label Sep 9, 2023
@BSPR0002 BSPR0002 force-pushed the filesystemdirectoryhandle branch from 303ef8c to 3af7e25 Compare September 14, 2023 12:18
@BSPR0002 BSPR0002 changed the title Correct descriptions of the asynchronous iterator methods on FileSystemDirectoryHandle. Correct descriptions of the asynchronous iterator methods on FileSystemDirectoryHandle Sep 14, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 14, 2023

Copy link
Contributor

@skyclouds2001 skyclouds2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

A suggestion: maybe just using the text of the overview of FileSystemDirectoryHandle interface is ok

See https://developer.mozilla.org/en-US/docs/Web/API/FileSystemDirectoryHandle

BSPR0002 and others added 7 commits October 15, 2023 03:54
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@BSPR0002 BSPR0002 force-pushed the filesystemdirectoryhandle branch from bd4d0d0 to 6005768 Compare October 14, 2023 19:54
@BSPR0002 BSPR0002 requested a review from Elchi3 November 5, 2023 13:06
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 👍

@Elchi3 Elchi3 merged commit ebd6de7 into mdn:main Nov 6, 2023
6 checks passed
@BSPR0002 BSPR0002 deleted the filesystemdirectoryhandle branch November 6, 2023 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:WebAPI Web API docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FileSystemDirectoryHandle.values() return value is incorrect
3 participants