Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URLSearchParams does not support nesting #14759

Merged
merged 1 commit into from
Jun 22, 2022
Merged

Conversation

tredondo
Copy link
Contributor

@tredondo tredondo commented Apr 6, 2022

Summary

Document that constructing a URLSearchParams from a record does not support nested records.

Also fix what the object was creating from in Examples.

Motivation

This was undocumented, and several very popular modules a deprecating themselves in favor of URLSearchParams.

Metadata

This PR…
-->

  • Adds a new document
  • Rewrites (or significantly expands) a document
  • Fixes a typo, bug, or other error

@tredondo tredondo requested a review from a team as a code owner April 6, 2022 19:56
@tredondo tredondo requested review from Elchi3 and removed request for a team April 6, 2022 19:56
@github-actions github-actions bot added the Content:WebAPI Web API docs label Apr 6, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2022

Preview URLs

Flaws

None! 🎉

External URLs

URL: /en-US/docs/Web/API/URLSearchParams/URLSearchParams
Title: URLSearchParams()
on GitHub

No new external URLs

(this comment was updated 2022-06-22 06:45:47.403885)

@sideshowbarker
Copy link
Member

Ted, thanks much, and congrats on landing your first docs change here — welcome aboard 🎉

@sideshowbarker sideshowbarker merged commit c7d7809 into mdn:main Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:WebAPI Web API docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants