Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chrome] Updates for Shadow DOM. #2806

Merged
merged 1 commit into from
Sep 27, 2018
Merged

[Chrome] Updates for Shadow DOM. #2806

merged 1 commit into from
Sep 27, 2018

Conversation

jpmedley
Copy link
Contributor

CustomElementRegistry

  • Sort support nodes
  • Shorten description of building
  • Add Chrome support for upgrade

DocumentOrShadowRoot

  • Sort members and support nodes

ShadowRoot

  • Sort members and support nodes
  • Add delegatesFocus

@Elchi3 Elchi3 added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Sep 13, 2018
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 👍

@Elchi3 Elchi3 merged commit 88278db into mdn:master Sep 27, 2018
@jpmedley jpmedley deleted the webcom branch September 27, 2018 14:54
"__compat": {
"mdn_url": "https://developer.mozilla.org/docs/Web/API/DocumentOrShadowRoot/styleSheets",
"mdn_url": "https://developer.mozilla.org/docs/Web/API/DocumentOrShadowRoot/adoptedStyleSheets",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I notice that https://developer.mozilla.org/docs/Web/API/DocumentOrShadowRoot/adoptedStyleSheets doesn’t exist yet — which is fine and I guess you’re already aware of — but since we don’t (yet) have any way to specify associated spec URLs in BCD (as discussed in #1531), I just want to note that very few other people looking at this data are likely to yet have any idea where DocumentOrShadowRoot: adoptedStyleSheets is actually specified (which is in the WICG Constructable Stylesheet Objects proposal).

To be clear: I’m not saying we shouldn’t add stuff like that to BCD — I think it’s fine — I’m just taking the opportunity to say, Gee wouldn’t it be great if when we did, we had a key in the BCD itself to indicate the associated spec.

cc @Elchi3

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, lets add spec urls soon. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants