Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Temporal timeZoneID -> timeZoneId, typo #25715

Merged
merged 1 commit into from
Jan 21, 2025
Merged

Rename Temporal timeZoneID -> timeZoneId, typo #25715

merged 1 commit into from
Jan 21, 2025
+3 −3

Conversation

bsmth
Copy link
Member

@bsmth bsmth commented Jan 20, 2025 •
edited
Loading

Summary

I'm going through Temporal entries and fixing a few oddities.

Changes:

  • Rename timeZoneID -> timeZoneId
  • typo in Temporal Instant; zoneddatetime -> instant

Related issues

@github-actions github-actions bot added the data:js Compat data for JS/ECMAScript features. https://developer.mozilla.org/docs/Web/JavaScript label Jan 20, 2025
@bsmth bsmth mentioned this pull request Jan 20, 2025
Merged
2 tasks
@github-actions github-actions bot added the size:s [PR only] 7-24 LoC changed label Jan 20, 2025
@bsmth bsmth mentioned this pull request Jan 20, 2025
Merged
3 tasks
@caugner caugner merged commit 3548b4a into mdn:main Jan 21, 2025
8 checks passed
@mdn-bot mdn-bot mentioned this pull request Jan 21, 2025
Merged
@bsmth bsmth deleted the rename-timezoneid branch January 21, 2025 13:10
@bsmth
Copy link
Member Author

bsmth commented Jan 21, 2025

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caugner caugner caugner approved these changes

Assignees
No one assigned
Labels
data:js Compat data for JS/ECMAScript features. https://developer.mozilla.org/docs/Web/JavaScript size:s [PR only] 7-24 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bsmth @caugner