-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Request()
constructor init.duplex
parameter
#25488
base: main
Are you sure you want to change the base?
Conversation
api/Request.json
Outdated
"chrome": { | ||
"version_added": "131" | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How did you determine this version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added in chromium/chromium@b4fc85b#diff-b20237250664d822b6a53088807fe79e7548b225c6001e555c1ef6389309aba6R26, and confirmed version in https://chromiumdash.appspot.com/commit/b4fc85b816b6e74d4c9ef60572bd66026c44d26a and https://issues.chromium.org/issues/40229369, so the version should be 105
api/Request.json
Outdated
"nodejs": [ | ||
{ | ||
"version_added": "19.3.0" | ||
}, | ||
{ | ||
"version_added": "18.13.0", | ||
"version_removed": "19.0.0" | ||
} | ||
], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you share links to the PRs/commits?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is added in nodejs/node@216b5a1#diff-1548e1d5e2941cd3f8042e4b5bf7f5f985e48bd7aee50f938739f9e067366e8cR476-R480, and nodejs/node#45236, so the version should be 19.1.0, 18.13.0, 16.19.0
"init_keepalive_parameter": { | ||
"__compat": { | ||
"description": "`init.keepalive` parameter", | ||
"mdn_url": "https://developer.mozilla.org/docs/Web/API/Request/keepalive", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ LGTM.
Summary
data taken from
Request.duplex
Test results and supporting details
Spec proposal change at whatwg/fetch#1493
Related issues
Relates to mdn/content#31735
Depends on #25486 and #25487