Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Request() constructor init.duplex parameter #25488

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

skyclouds2001
Copy link
Contributor

@skyclouds2001 skyclouds2001 commented Dec 22, 2024

Summary

data taken from Request.duplex

Test results and supporting details

Spec proposal change at whatwg/fetch#1493

Related issues

Relates to mdn/content#31735
Depends on #25486 and #25487

@github-actions github-actions bot added data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API size:m [PR only] 25-100 LoC changed labels Dec 22, 2024
@github-actions github-actions bot added the data:browsers Data about browsers (versions, release dates, etc). This data is used for validation. label Dec 29, 2024
@skyclouds2001 skyclouds2001 marked this pull request as ready for review December 29, 2024 14:24
api/Request.json Outdated
Comment on lines 227 to 229
"chrome": {
"version_added": "131"
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did you determine this version?

Copy link
Contributor Author

@skyclouds2001 skyclouds2001 Jan 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

api/Request.json Outdated
Comment on lines 245 to 253
"nodejs": [
{
"version_added": "19.3.0"
},
{
"version_added": "18.13.0",
"version_removed": "19.0.0"
}
],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you share links to the PRs/commits?

Copy link
Contributor Author

@skyclouds2001 skyclouds2001 Jan 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"init_keepalive_parameter": {
"__compat": {
"description": "`init.keepalive` parameter",
"mdn_url": "https://developer.mozilla.org/docs/Web/API/Request/keepalive",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API data:browsers Data about browsers (versions, release dates, etc). This data is used for validation. size:m [PR only] 25-100 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants