Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spec_url for html.elements.li.type #24983

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

skyclouds2001
Copy link
Contributor

Summary

Test results and supporting details

Related issues

@github-actions github-actions bot added the data:html Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML label Nov 7, 2024
@skyclouds2001 skyclouds2001 marked this pull request as ready for review November 7, 2024 09:07
Copy link
Contributor

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if we should add a spec url for obsolete features. The referenced part of the spec doesn't have any specified behavior, and the resulting standard track status may be misleading.

Requesting a second opinion from @Elchi3.

Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is another reason why we want to remove standard_track long-term. It is somewhat confusing if it implies some sort of blessing in cases like this one or has any additional meaning. However, per the guidelines, currently, standards_track true is set if "the feature is part of an active specification". which is given here even though it is in the "obsolete" section of that active spec. There are quite a few obsolete features that are in active specs and they can't be removed for compat reasons and to not break old websites.

I guess you've set it to true because otherwise the linter will complain about it due to the added spec_url.

The spec_url link is very useful in my opinion as the pointer to the spec lets your learn that the spec considers this feature "obsolete" (which has consequences for this features' "deprecated" BCD status.). Setting standards_track to true looks a bit weird now, but I think if we understand it purely as "mentioned in an active spec" then it is okay for it to be set to true. Again, ideally BCD just provides spec_urls and gets rid of our somewhat poorly defined standards_track status in the future. See #1531.

@skyclouds2001
Copy link
Contributor Author

I discover it when working on mdn/content#36687, and HTMLLIElement.value is marked as standard but deprecated with the spec_url key specfied

@caugner caugner merged commit 457dde6 into mdn:main Nov 12, 2024
5 checks passed
@skyclouds2001 skyclouds2001 deleted the html.elements.li.type branch November 12, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:html Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants