Add missing statements for webview_ios #24657
Draft
+20
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I tried to generate web-features locally using WebViews as part of the browser set. I found that there were a few keys that webview_ios wasn't set for. As far as I can see, in each of the places it was missing it was set as mirror for other keys for those elements.
github-actions
bot
added
the
data:html
|
Leaving this open for the moment, will return to it. I will just flag that there are a few places like this that will mean we can't run baseline for WebViews yet. |
This comment was marked as outdated.
This comment was marked as outdated.
caugner
reviewed
Oct 7, 2024
| @@ -68,7 +68,8 @@ | |||
| }, | |||
| "safari_ios": "mirror", | |||
| "samsunginternet_android": "mirror", | |||
| "webview_android": "mirror" | |||
| "webview_android": "mirror", | |||
| "webview_ios": "mirror" | |||
There was a problem hiding this comment.
This causes this error:
✖ html.elements.del - Error → Basic support in webview_ios was declared implemented in a later version (3.2) than the following sub-feature(s):
→ html.elements.del.cite: 2
→ html.elements.del.datetime: 2
However, the same applies to Safari, which says 3 for the subfeature and ≤4 for the parent feature. So I'm not sure why it only fails for the subfeature?
There was a problem hiding this comment.
This is due to an issue with mirroring where the downstream browser became a non-range no matter what. This will be resolved by #24155!
queengooborg
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to generate web-features locally using WebViews as part of the browser set.
I found that there were a few keys that
webview_ioswasn't set for.As far as I can see, in each of the places it was missing it was set as mirror for other keys for those elements.