Storage Updates

[rebloor]

Summary

This change:

• Address is the compatibility updates needed for Bug 1908925
  "storage.session quota is not enforced" to cover the implementation of storage.session.getBytesInUse and storage.session.QUOTA_BYTES
• for clarity, exemplified the Storage area method types etc. under each storage area.

Related issues

Related content changes for Bug 1908925 or in mdn/content#35629

[rebloor]

@zombie or @Rob--W could I get your review on this BCD?

[Rob--W]

I'm requesting changes, to apply all of the following suggested edits:

• inaccurate storage.local.getBytes & storage.sync.getBytes data (you swapped the two).
• Drop extra_key from managed API (2x) because it is not relevant.
• Update chrome versions in extra_key to match the parent version.

After applying all of these suggested updates, please do a search and replace in this file, to replace ≤58 with ≤18, since that is the version where these APIs existed; at least where the getBytesInUse method was introduced. Source:

• https://source.chromium.org/chromium/chromium/src/+/7b4989f11ac8619e2e72305700e3faa846765c68
• https://source.chromium.org/chromium/chromium/src/+/7b4989f11ac8619e2e72305700e3faa846765c68:chrome/VERSION

[Rob--W]

Suggested change

	"version_added": "≤105"
	"version_added": "≤58"

[Rob--W]

The sync compatibility information for Firefox for Android is incorrect. You have currently set it to 48 (true at the top level), but it should be "53". That mirrors desktop, but we cannot just use "mirror" here because there is a compatibility note that should be kept (i.e. that storage.sync does not sync on Android).

And please fix the Chrome compat information as requested at https://github.com/mdn/browser-compat-data/pull/24272#pullrequestreview-2332762107:>

After applying all of these suggested updates, please do a search and replace in this file, to replace ≤58 with ≤18, since that is the version where these APIs existed; at least where the getBytesInUse method was introduced. Source:

• https://source.chromium.org/chromium/chromium/src/+/7b4989f11ac8619e2e72305700e3faa846765c68
• https://source.chromium.org/chromium/chromium/src/+/7b4989f11ac8619e2e72305700e3faa846765c68:chrome/VERSION

[danielhjacobs]

The sync compatibility information for Firefox for Android is incorrect. You have currently set it to 48 (true at the top level), but it should be "53". That mirrors desktop, but we cannot just use "mirror" here because there is a compatibility note that should be kept (i.e. that storage.sync does not sync on Android).

And please fix the Chrome compat information as requested at https://github.com/mdn/browser-compat-data/pull/24272#pullrequestreview-2332762107:>

After applying all of these suggested updates, please do a search and replace in this file, to replace ≤58 with ≤18, since that is the version where these APIs existed; at least where the getBytesInUse method was introduced. Source:

• https://source.chromium.org/chromium/chromium/src/+/7b4989f11ac8619e2e72305700e3faa846765c68
• https://source.chromium.org/chromium/chromium/src/+/7b4989f11ac8619e2e72305700e3faa846765c68:chrome/VERSION

All the Firefox for Android 48 updates here seem to relate to this table: https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/storage/StorageArea#browser_compatibility

Your review comment relates to https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/storage/sync#browser_compatibility

This PR doesn't actually touch that line (line 445 currently, line 992 in this PR)

[Rob--W]

All the Firefox for Android 48 updates here seem to relate to this table: https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/storage/StorageArea#browser_compatibility

Your review comment relates to https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/storage/sync#browser_compatibility

This PR doesn't actually touch that line (line 445 currently, line 992 in this PR)

This PR adds BCD entries to every storage namespace, whose version information may differ from where the original version was introduced.

With such a large diff/file it is not obvious what would be going on, so I put a quick preview tool together that generates a table based on the input. You can see it at https://jsbin.com/subipeyibo/edit?output and input the latest commit, currently:
https://github.com/mdn/browser-compat-data/raw/8987eb0a03b7ae2ea630fb09a242397a3652a3b4/webextensions/api/storage.json

The rendered table shows incorrect version information for the storage.sync API.

[Rob--W]

To recap (plus more specific details):

chrome in sync and local namespaces:

• ≤58 to 19
• Source: https://source.chromium.org/chromium/chromium/src/+/7b4989f11ac8619e2e72305700e3faa846765c68
• Version: https://source.chromium.org/chromium/chromium/src/+/7b4989f11ac8619e2e72305700e3faa846765c68:chrome/VERSION
• Note: 19 not 18 because 1027 is higher than 1025, because of inaccurate version around branch date till Chrome 39, as explained in Update Chromium data for storage Web Extensions interface #24279 (comment)

chrome in managed namespace:

• ≤58 to 33
• Source: https://source.chromium.org/chromium/chromium/src/+/8fdf1ef21743a36b974614fb95da02d3172fa91c
• Version: https://source.chromium.org/chromium/chromium/src/+/8fdf1ef21743a36b974614fb95da02d3172fa91c:chrome/VERSION
• note: version is correct, because 1732 is lower than 1750, the build number associated with Chrome 33. (Had to double check because version is not 39+, see Update Chromium data for storage Web Extensions interface #24279 (comment))

firefox_android in sync namespace:

• sync from true to 53 with note that it doesn't sync AND that quota is not yet enforced.
• sync methods all from 48/mirror to mirror (or 53 with same note)
• sync.onChanged kept at mirror (or 111 with same note).
• sync.getBytesInUse from false to 78 with same note. (Not mirror here because the note on quota enforcement is relevant)

[rebloor]

@Rob--W, hopefully, those changes are made; however, I didn't fully follow your request regarding firefox_android in the sync namespace. We don't normally cascade notes down, but did you want the notes about the absence of sync and management of quota on all of the sub-items? Also, for sync.onChanged did you mean 101?

[Rob--W]

All looks good! And thanks for catching my typo, it should indeed have been 101 instead of 111.

[danielhjacobs]

Since this now includes the changes from #24525, it needs the "KR: Real BCD" label.