Add missing features for accent-color CSS property #22571
Draft
+800
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds the missing features of the `accent-color` CSS property. The data comes from the [mdn-bcd-collector](https://mdn-bcd-collector.gooborg.com) project (v10.10.0). _Check out the [collector's guide on how to review this PR](https://github.com/openwebdocs/mdn-bcd-collector#reviewing-bcd-changes)._ Tests Used: https://mdn-bcd-collector.gooborg.com/tests/css/properties/accent-color
queengooborg
added
the
data:css
Elchi3
requested changes
Jun 6, 2024
There was a problem hiding this comment.
Not sure if it is worth adding these.
- They are all deprecated (need to set the status to true).
- spec urls are missing, see https://drafts.csswg.org/css-color-4/#deprecated-system-colors
|
Alternatively, if we want to add these, we should summarize them in one entry "deprecated_color_names" or so. |
|
These all come from Webref, so if we don't want to add them or we want to combine them all into one entry (which I recommend not doing as it makes BCD less machine-readable), we'll need to update the collector to ignore them. |
|
BCD already combines named colors to one entry, so for https://drafts.csswg.org/css-color-4/#named-colors we have css.types.color.named-color. I think the same should happen for deprecated-color-name. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the missing features of the
accent-colorCSS property. The data comes from the mdn-bcd-collector project (v10.10.0).Check out the collector's guide on how to review this PR.
Tests Used: https://mdn-bcd-collector.gooborg.com/tests/css/properties/accent-color